HOTFIX: fix TDD test

lib/proptrackr_web/controllers/properties_controller.ex

@@ -38,25 +38,25 @@ defmodule PropTrackrWeb.PropertiesController do
       select: p
     )
 
-    current_user = conn.assigns.current_user
-    can_edit = current_user && current_user.id == property.user_id
-
-    favorites = case current_user do
-      nil -> []
-      user ->
-        Repo.all(
-          from f in Favorite,
-          where: f.user_id == ^user.id,
-          select: f.property_id
-        )
-    end
-
     case property do
       nil ->
         conn
         |> put_flash(:error, "Property not found.")
         |> redirect(to: ~p"/")
       property ->
+        current_user = conn.assigns.current_user
+        can_edit = current_user && current_user.id == property.user_id
+
+        favorites = case current_user do
+          nil -> []
+          user ->
+            Repo.all(
+              from f in Favorite,
+              where: f.user_id == ^user.id,
+              select: f.property_id
+            )
+        end
+
         render(conn, "show.html",
           property: property,
           can_edit: can_edit,

test/proptrackr_web/controllers/my_advertisements_controller_test.exs

@@ -140,7 +140,9 @@ defmodule PropTrackrWeb.MyPropertiesControllerTest do
 
     # Try to access non-existent property
     conn = get(conn, "/properties/non-existent-reference")
-    assert html_response(conn, 500) =~ "Not found"
+    assert redirected_to(conn) == "/"
+    conn = get conn, redirected_to(conn)
+    assert get_flash(conn, :error) == "Property not found."
   end
 
   defp setup_session(conn, user) do