Update Peer Review authored by vanessaa's avatar vanessaa
1. **Code review.**
* Overall the code looks well-structured and seems to be working right.
1. **Code review.**
* Overall the code looks well-structured and seems to be working right.
* The code is quite well commented
* resources/views/muudatellimus.blade.php is quite long file and includes a mix of logic, layout, and content, maybe this could be broken down into components.
* The select options are hardcoded to the code (e.g. in resources/views/muudatellimus.blade.php). Maybe fetching the different fish types from a database could be more dynamic and maintainable.
* Code has a mix of English and Estonian in naming conventions, next time could be better to stick with one language
* The select options are hardcoded to the code (e.g. in resources/views/muudatellimus.blade.php). Maybe fetching the different fish types from a database could be more dynamic and maintainable.
* Code has a mix of English and Estonian in naming conventions, next time could be better to stick with one language
* Shouldn't the order number be automatically generated because right now I can make two orders with the same order number.
2. **Installation test.**
* steps to install the application were very clear and easy to follow. There were no issues with the installation part.
3. **Acceptance test.**
* steps to install the application were very clear and easy to follow. There were no issues with the installation part.
3. **Acceptance test.**
* I am not sure but I didn't see a option to add urgency, the US is marked as could-have so maybe it is to implemented yet (US-5: As a courier, I want the system to calculate the optimal route considering the urgency and stage of orders so that I can follow the most time-sensitive schedule efficiently.)
* UC-5 Calculate route. "The system displays key route information, including the estimated travel time and distance in kilometers." (Currently distance is only displayed)
* Would it be possible to arrange the orders in the table to match the delivery sequence planned for the courier's route? So, it would be clearer in what sequence the orders should be delivered.
* UC-5 Calculate route. "The system displays key route information, including the estimated travel time and distance in kilometers." (Currently distance is only displayed)
* Would it be possible to arrange the orders in the table to match the delivery sequence planned for the courier's route? So, it would be clearer in what sequence the orders should be delivered.
* I cannot check this, but is this working? US-14 As a courier, I want the system to be linked to the POS, so that I don’t have to manually enter all the orders.
* I think, this is also not implemented but once again it is marked as a could-have. US-16 As a courier, I want to be able to prioritise certain orders so that they’d show up at the top of the Delivery Planning View.
* I think the reset my password requirement is not working, at least I didn't receive a email with the option to change the password. US-23 As a courier, I want to be able to reset my password, so that I can regain access to the application if I forget my password.
* I think this is also not implemented but once again it is marked as a could-have. US-16 As a courier, I want to be able to prioritise certain orders so that they’d show up at the top of the Delivery Planning View.
* I think the reset my password requirement is not working, at least I didn't receive a email with the option to change the password. US-23 As a courier, I want to be able to reset my password, so that I can regain access to the application if I forget my password.
4. **Some suggestions.**
* When creating a new order, it might be helpful to clearly indicate that the quantity of fish is counted by pieces, not in kilograms, as this caused me some confusion at first. On the Orders page, it’s clearly stated that the quantity refers to the number of fish, which is great.
* When creating a new order, it might be helpful to clearly indicate that the quantity of fish is counted by pieces, not in kilograms, as this caused me some confusion at first. On the Orders page, it’s clearly stated that the quantity refers to the number of fish, which is great.
* I’m not sure if anything can be done, but the map occasionally lagged when I tried to zoom in or out.
* The "Delivered/Done Orders" text could be made more noticeable (perhaps as a button) because I almost missed the option to view those orders.
* The "Delivered/Done Orders" text could be made more noticeable (perhaps as a button) because I almost missed the option to view completed orders.
* what does the date mean? the date when the order was made or the date when the order has to be delivered?
\ No newline at end of file