Update Peer Review authored by vanessaa's avatar vanessaa
1. Code review. Pull the code from the source code repository, build it and analyze the source code. List the bugs you found, design issues, antipatterns, inefficient code, etc.
2. Installation test. From the source code, get the application up and running in your environment. Describe the problems you faced and propose solutions to ease the installation.
* not really a problem, but a suggestion: when making a new order the could be like a word that says that the fish is by the amount not in kilograms or something like that. (I was a little confused for a second). In the Orders pages there is nicely said that it is the amount of fish
* the map was kinda slow sometimes
* maybe the delivered/done orders text could be more seeable, I almost didn't see the option to look at these orders US-18 **\[Order Organisation\]** As a courier, I want to be able to look at all previously completed orders so I can quickly reference previous orders.
3. Acceptance test. Taking requirements into account, check the functionality of the application and verify whether it corresponds to the requirements. Make sure what features are supposed to work in the version you are conducting tests upon, you might need to communicate with the reviewed team for this.
* I am not sure but I didn't see a option to add urgency, the US is marked as could-have so maybe it is to implemented yet (US-5: **\[Route planning\]** As a courier, I want the system to calculate the optimal route considering the urgency and stage of orders so that I can follow the most time-sensitive schedule efficiently.)
* Similar to this the UC-5 Calculate route. The system calculates the shortest path between the order locations, taking into account the order (sequence) in which the orders are in the route plan. (how can I change the order ) The system displays key route information, including the estimated travel time and distance in kilometers. (Currently distance is only displayed)
* Is that working? US-14 **\[Order management\]** As a courier, I want the system to be linked to the POS, so that I don’t have to manually enter all the orders.
* this is also not implemented? but once again it is marked as could-have. US-16 **\[Order Organisation\]** As a courier, I want to be able to prioritise certain orders so that they’d show up at the top of the Delivery Planning View.
* KONTROLLI SEDA!!!!! **\[Account management\]** As a courier, I want to be able to reset my password, so that I can regain access to the application if I forget my password. Priority: High
*
\ No newline at end of file
1. **Code review.**
* Overall the code looks well-structured and seems to be working right.
* The code is quite well commented
* resources/views/muudatellimus.blade.php is quite long file and includes a mix of logic, layout, and content, maybe this could be broken down into components.
* The select options are hardcoded to the code (e.g. in resources/views/muudatellimus.blade.php). Maybe fetching the different fish types from a database could be more dynamic and maintainable.
* Code has a mix of English and Estonian in naming conventions, next time could be better to stick with one language
* Shouldn't the order number be automatically generated because right now I can make two orders with the same order number.
2. **Installation test.**
* steps to install the application were very clear and easy to follow. There were no issues with the installation part.
3. **Acceptance test.**
* I am not sure but I didn't see a option to add urgency, the US is marked as could-have so maybe it is to implemented yet (US-5: As a courier, I want the system to calculate the optimal route considering the urgency and stage of orders so that I can follow the most time-sensitive schedule efficiently.)
* UC-5 Calculate route. "The system displays key route information, including the estimated travel time and distance in kilometers." (Currently distance is only displayed)
* Would it be possible to arrange the orders in the table to match the delivery sequence planned for the courier's route? So, it would be clearer in what sequence the orders should be delivered.
* I cannot check this, but is this working? US-14 As a courier, I want the system to be linked to the POS, so that I don’t have to manually enter all the orders.
* I think, this is also not implemented but once again it is marked as a could-have. US-16 As a courier, I want to be able to prioritise certain orders so that they’d show up at the top of the Delivery Planning View.
* I think the reset my password requirement is not working, at least I didn't receive a email with the option to change the password. US-23 As a courier, I want to be able to reset my password, so that I can regain access to the application if I forget my password.
4. **Some suggestions.**
* When creating a new order, it might be helpful to clearly indicate that the quantity of fish is counted by pieces, not in kilograms, as this caused me some confusion at first. On the Orders page, it’s clearly stated that the quantity refers to the number of fish, which is great.
* I’m not sure if anything can be done, but the map occasionally lagged when I tried to zoom in or out.
* The "Delivered/Done Orders" text could be made more noticeable (perhaps as a button) because I almost missed the option to view those orders.
* what does the date mean? the date when the order was made or the date when the order has to be delivered?
\ No newline at end of file